Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests using port 5000 conflict with OS service on recent versions of macOS under some circumstances #1218

Closed
cardenaso11 opened this issue Dec 14, 2023 · 2 comments · Fixed by #1230
Assignees
Labels
bug 🐛 Something isn't working
Milestone

Comments

@cardenaso11
Copy link
Contributor

cardenaso11 commented Dec 14, 2023

Context & versions

Present on recent master, 6e7b43a at minimum. I can reproduce on aarch64-darwin, macOS 14.1.2 23B92. cardano-node obtained from flake input, run as x86_64-darwin, via rosetta

Steps to reproduce

On a recent macOS device, if AirPlay receiving is enabled in System preferences, port 5000 will already be in use, and several hydra-cluster tests will fail sporadically. This might have gone unnoticed due to the nix shell for macOS not containing a cardano-node by default, causing lots of tests to skip running by default

Actual behavior

Tests sporadically fail due to not being able to open the port

Expected behavior

Tests should always run on macOS. Tests can change the port from 5000 (like starting hydra-cluster tests off at an offset like 5100, which is what I did as a temporary fix during development). In addition, it might be good to fail more explicitly if ports can't be opened for any reason

@cardenaso11 cardenaso11 added the bug 🐛 Something isn't working label Dec 14, 2023
@cardenaso11
Copy link
Contributor Author

Updating this with details

@cardenaso11
Copy link
Contributor Author

I have a fix in the offline mode branch for just changing the port, going to add that here and see what I can do about making the port failures more clear

cardenaso11 added a commit to SundaeSwap-finance/hydra that referenced this issue Dec 15, 2023
ch1bo pushed a commit to SundaeSwap-finance/hydra that referenced this issue Dec 18, 2023
ch1bo pushed a commit to SundaeSwap-finance/hydra that referenced this issue Dec 18, 2023
@ch1bo ch1bo assigned ffakenz and unassigned ffakenz Dec 19, 2023
@ch1bo ch1bo added this to the 0.15.0 milestone Dec 22, 2023
@ffakenz ffakenz self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants