Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI: Add recipient address entry #1607

Merged
merged 5 commits into from
Sep 8, 2024
Merged

TUI: Add recipient address entry #1607

merged 5 commits into from
Sep 8, 2024

Conversation

ch1bo
Copy link
Member

@ch1bo ch1bo commented Sep 6, 2024

  • Adds a new option when selecting the recipient to allow for a "manual entry"

image

  • Validates entered addresses to be valid bech32

image

  • Fixes event handling to a point where copy & paste works
    • Before the event handlers for quitting and showing/disabling logs were interfering
    • Only display and handle log controls when no modal open

  • CHANGELOG updated
  • Documentation update not needed
  • Haddocks update not needed
  • No new TODOs introduced

@ch1bo ch1bo requested a review from a team September 6, 2024 15:52
@ch1bo ch1bo self-assigned this Sep 6, 2024
@ch1bo ch1bo force-pushed the tui-address-entry branch from a104f9c to 1475bc3 Compare September 6, 2024 15:54
Copy link

github-actions bot commented Sep 6, 2024

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2024-09-08 10:53:52.707382067 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 2fac819a1f4f14e29639d1414220d2a18b6abd6b8e444d88d0dda8ff 3799
νCommit 2043a9f1a685bcf491413a5f139ee42e335157c8c6bc8d9e4018669d 1743
νHead bd9fad235c871fb7f837c767593018a84be3083ff80f9dab5f1c55f9 10194
μHead c8038945816586c4d38926ee63bba67821eb863794220ebbd0bf79ee* 4607
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 5196 5.61 2.21 0.44
2 5394 7.09 2.80 0.47
3 5597 8.73 3.46 0.49
5 6000 11.45 4.53 0.54
10 7010 18.02 7.12 0.66
56 16253 81.66 32.30 1.76

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 569 10.52 4.15 0.29
2 755 13.86 5.65 0.34
3 945 17.33 7.20 0.38
5 1317 24.65 10.44 0.48
10 2258 45.22 19.36 0.75
20 4123 95.99 40.76 1.40

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 560 21.46 8.41 0.41
2 114 671 33.97 13.43 0.55
3 170 782 46.22 18.48 0.69
4 225 893 59.10 23.88 0.84
5 282 1004 79.71 32.26 1.07
6 340 1116 96.59 39.37 1.26

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 640 17.93 7.87 0.38
2 731 17.80 8.51 0.39
3 904 20.76 10.44 0.43
5 1168 22.80 12.64 0.48
10 1980 32.54 20.12 0.65
49 7856 99.00 74.38 1.83

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 644 21.02 9.41 0.42
2 818 22.49 10.83 0.45
3 919 23.84 12.17 0.47
5 1186 26.90 15.02 0.53
10 1988 35.50 23.06 0.69
49 7895 97.18 82.25 1.88

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 676 27.14 11.66 0.48
2 885 29.38 13.56 0.52
3 1025 30.98 15.00 0.55
5 1334 34.95 18.36 0.62
10 2001 44.04 26.15 0.78
38 6450 99.17 73.04 1.76

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 5102 17.43 7.59 0.57
2 5252 29.24 12.89 0.71
3 5356 42.50 18.80 0.86
4 5427 56.35 24.94 1.02
5 5556 71.14 31.47 1.20
6 5780 97.50 43.45 1.51

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 5033 7.95 3.36 0.46
5 1 57 5068 9.08 4.08 0.48
5 5 284 5203 13.21 6.75 0.53
5 10 571 5374 18.87 10.31 0.61
5 20 1141 5714 30.67 17.63 0.78
5 30 1709 6054 42.10 24.80 0.94
5 40 2277 6392 53.23 31.84 1.09
5 50 2840 6725 64.17 38.80 1.24
5 81 4612 7784 99.73 61.10 1.74

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2024-09-08 10:56:21.418147904 UTC

Baseline Scenario

Number of nodes 1
Number of txs 3000
Avg. Confirmation Time (ms) 4.617196864
P99 9.342125739999922ms
P95 5.9449925ms
P50 4.396366ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 9000
Avg. Confirmation Time (ms) 24.017894112
P99 105.27040219000004ms
P95 33.26383734999999ms
P50 21.595625ms
Number of Invalid txs 0

Copy link

github-actions bot commented Sep 6, 2024

Test Results

459 tests  ±0   454 ✅ ±0   20m 30s ⏱️ + 1m 27s
138 suites ±0     5 💤 ±0 
  5 files   ±0     0 ❌ ±0 

Results for commit 45e27e3. ± Comparison against base commit 6d40870.

♻️ This comment has been updated with latest results.

@locallycompact locallycompact enabled auto-merge (squash) September 8, 2024 10:45
@locallycompact locallycompact merged commit 20ceaa7 into master Sep 8, 2024
38 checks passed
@locallycompact locallycompact deleted the tui-address-entry branch September 8, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants