-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quickly try speeding up CI workflow by parallelizing tasks. #297
Conversation
shell.nix
Outdated
@@ -7,6 +7,8 @@ | |||
|
|||
, hsPkgs ? import ./default.nix { } | |||
|
|||
, githubWorkflow ? false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: rename -> withDevTools
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or withoutDevTools
- package: plutus-merkle-tree | ||
- package: hydra-tui | ||
- package: hydra-node | ||
bench: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are these used? I don't see any reference to bench
anywhere else in this file and looking at the CI execution trace I don't see they are executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see they are not referenced in steps
as in example https://docs.github.com/en/github-ae@latest/actions/using-jobs/using-a-build-matrix-for-your-jobs#example-running-multiple-versions-of-nodejs only package
is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was simply to check that the workflow syntax was okay 😊 ... Going step-by-step, I wanted to introduce jobs taking care of the benchmarks later.
Thus indeed, for now, they aren't used.
Avoid hoogle, and unnecessary dev tools.
0a86e6c
to
e3a7eb4
Compare
4f06f0e
to
4b7dd65
Compare
f89f600
to
66f6808
Compare
66f6808
to
c39fa1b
Compare
a5ca816
to
ac4241c
Compare
ac4241c
to
918f492
Compare
Using the XTerm terminal seems to be rather flaky and sometimes not start for unknown reason.
(work in progress, and very much experimental)