Add CloseTx cost benchmark to tx-cost and similar test suites #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move it to `Hydra.Snapshot` and use it in the `Arbitrary ConfirmedSnapshot` instance, which also benefits of higher frequency `ConfirmedSnapshot`.
|
I like our test suite is steadily growing, I am considering publishing it on our documentation website. |
ghost
approved these changes
Apr 22, 2022
| , fanout | ||
| , mt | ||
| , h | ||
| ] |
| (not (isInitialSnapshot snapshot)) | ||
| "Close with multi-signed snapshot" | ||
| -- TODO: label / classify tx and snapshots to understand test failures | ||
| forAll (genCloseTx 3) $ uncurry action |
There was a problem hiding this comment.
I rebased things. Likely the next PR (from our ensemble work) will address this.
| let stInitialized = executeCommits initTx commits stIdle | ||
| in action stInitialized (collect stInitialized) | ||
| forAllCollectCom action = | ||
| forAll (genCollectComTx 3) $ uncurry action |
What bit of it? The testing strategy? |
|
@ch1bo No, the whole output of tests run. Like we publish benchmarks output, publishing tests output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.