Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Ord HeadId #918

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

uhbif19
Copy link
Contributor

@uhbif19 uhbif19 commented Jun 10, 2023

I see no reasons why Ord is worse than Eq.

This is not public API, I think, so no CHANGELOG, right?


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@uhbif19
Copy link
Contributor Author

uhbif19 commented Jun 10, 2023

@ch1bo

Seems like Actions are broken for outside PRs?

path '/home/runner/work/hydra/hydra/plutus-cbor' does not contain a 'flake.nix', searching up
fatal: reference is not a tree: 7313b0001a347895c5[6](https://github.com/input-output-hk/hydra/actions/runs/5229712380/jobs/9442854623?pr=918#step:6:7)eeaeb8dc06af9db00fd1[7](https://github.com/input-output-hk/hydra/actions/runs/5229712380/jobs/9442854623?pr=918#step:6:8)
error:
       … while fetching the input 'git+file:///home/runner/work/hydra/hydra'

@ch1bo
Copy link
Member

ch1bo commented Jun 12, 2023

@ch1bo

Seems like Actions are broken for outside PRs?

Yes, unfortunately the nix build with flakes does not play well with forks.

@ch1bo ch1bo force-pushed the uhbif19/derive-headid-ord branch from 7313b00 to b8b1eaf Compare June 12, 2023 11:12
@ch1bo ch1bo merged commit fed8a79 into cardano-scaling:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants