-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry to ALL reward services #2958
Conversation
"streamlit>=1.9.0", | ||
"hexbytes>=0.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(new2) tintinthong@Justins-MacBook-Pro cardpay-reward-programs % pdm add -G explore hexbytes
Adding packages to explore dependencies: hexbytes
✖ 🔒 Lock failed
Unable to find a resolution because the following dependencies don't work on all Python versions defined by the project's `requires-python`: >=3.9
python>=3.6,<3.11 (from <Candidate eth-typing 2.3.0 from https://pypi.org/simple/eth-typing/>)
python>=3.6,<3.11 (from <Candidate eth-typing 2.3.0 from unknown>)
To fix this, you can change the value of `requires-python` in pyproject.toml.
See /var/folders/hv/qnr8mqkn4zxcgt1rg18sbbjw0000gn/T/pdm-lock-zdoozpdq.log for detailed debug log.
[ResolutionImpossible]: Unable to find a resolution
There are some resolution errors when adding hexbytes
. I resolved this by narrowing the requires-python
range. Probably related issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting. I guess if we set an upper bound to the python version this package supports to 3.10 this might go away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this is what I did it seemed to work
@tintinthong I'm adding sentry to the scheduler project yeah |
@IanCal this pr is paired with this https://github.com/cardstack/infra/pull/165 |
Note: Decided to commit original lock file Adding dev dependency I suspect that the main culprit is in installing the dependency |
## Issues running on M1 | ||
|
||
If you use an m1 (arm64 architecture) you may encounter errors when sub-dependencies do not have arm64 distribution. | ||
|
||
One way to resolve this is to follow [here](https://towardsdatascience.com/how-to-use-manage-multiple-python-versions-on-an-apple-silicon-m1-mac-d69ee6ed0250). The solution is to use Rosetta for `x86` terminal emulation. After doing so, you will have a separate pdm installation in `/usr/local/bin` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important to ensure that your emulated pdm is pointing to the correct python -- tripped me up quite a bit.
Adds sentry logging to all reward services.
Linear ticket: cs-2711
[ ] scheduler@IanCal adding scheduler sentry along side with passing sentry dsn into reward rules