Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localization look up through SPM #566

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Fix localization look up through SPM #566

merged 1 commit into from
Apr 5, 2021

Conversation

ApolloZhu
Copy link
Contributor

Accessing localized resources, if integrated using Swift Package Manager, requires using Bundle.module:

let localizedString = NSLocalizedString(”a_localized_string”, bundle: Bundle.module, comment: “a comment”).

This pull request fixes this issue in CareKitUI.

@ApolloZhu
Copy link
Contributor Author

Well, CareKitStore doesn't even use loc so I'm not sure why this test failed:

TestStoreOutcomes
    ✗ testAddAndFetchOutcomes, failed: caught error: "timedOut(reason: "Timed out after 10.0 seconds.")"

@erik-apple
Copy link
Collaborator

Great catch! Thanks for this PR!

@erik-apple erik-apple merged commit 716e47f into carekit-apple:main Apr 5, 2021
@erik-apple
Copy link
Collaborator

Congrats on your first contribution @ApolloZhu!
I hope we'll see many more in the future!

@Hatsushira Hatsushira mentioned this pull request Jun 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-apple erik-apple erik-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ApolloZhu @erik-apple