Prettier UI #260
Closed
Prettier UI #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passcod
force-pushed
the
ux
branch
2 times, most recently
from
e175a18 to
14bbc9d
Compare
Given it is not always a symlink, and the symlink bit is really an internal detail
passcod
force-pushed
the
ux
branch
2 times, most recently
from
55070bf to
8195e0e
Compare
NobodyXu
requested changes
Jul 30, 2022
NobodyXu
requested changes
Jul 30, 2022
NobodyXu
requested changes
Jul 30, 2022
NobodyXu
requested changes
Jul 30, 2022
| Ok(()) | ||
| } | ||
|
|
||
| fn install_copy(src: &Path, dst: &Path) -> Result<(), BinstallError> { |
There was a problem hiding this comment.
Can we make install_copy atomic by first creating a NamedTempFile?
| ); | ||
|
|
||
| #[cfg(unix)] | ||
| { |
There was a problem hiding this comment.
It's actually possible to also make symlink atomic.
Check the original helpers::atomic_symlink for implementation.
NobodyXu
requested changes
Jul 30, 2022
This was referenced Aug 3, 2022
|
There are so many merge conflicts on this PR... |
|
Going to close this and redo it later |
It's probably better to split it into multiple small PRs as that would make merging much easier and less likely to have conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
--no-confirm--no-symlinksto--no-versioned(keeps the old name as alias for now)--no-versionedbehaves to be in line with the option help text and align with expectationsWhen the terminal is not interactive, it defaults to
no-confirmand switches to log view: