Add tests for opportunistic linkage

See discussion at Homebrew/brew#12454.
carlocab · Nov 22, 2021 · 7a6569d · 7a6569d
1 parent 53b06a1
commit 7a6569d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/tests/formulae.rb b/lib/tests/formulae.rb
@@ -360,6 +360,12 @@ def formula!(formula_name, args:)
         failed_linkage_or_test_messages ||= []
         failed_linkage_or_test_messages << "linkage failed" unless steps.last.passed?
 
+        # Check for opportunistic linkage. Ignore failures because
+        # they can be unavoidable but we still want to know about them.
+        test "brew", "linkage", "--test", "--strict",
+             named_args:      formula_name
+             ignore_failures: true
+
         test "brew", "install", "--only-dependencies", "--include-test", formula_name
 
         if formula.test_defined?

diff --git a/lib/tests/formulae_dependents.rb b/lib/tests/formulae_dependents.rb
@@ -168,6 +168,12 @@ def install_dependent(dependent, testable_dependents, args:, build_from_source:
              ignore_failures: !bottled_on_current_version
         linkage_step = steps.last
 
+        # Check for opportunistic linkage. Ignore failures because
+        # they can be unavoidable but we still want to know about them.
+        test "brew", "linkage", "--test", "--strict",
+             named_args:      dependent.full_name,
+             ignore_failures: true
+
         if testable_dependents.include? dependent
           test "brew", "install", "--only-dependencies", "--include-test", dependent.full_name