More properly handle FileFlags

carlopi · Dec 9, 2024 · 039ad78 · 039ad78
1 parent d6aec61
commit 039ad78
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/include/duckdb/web/io/web_filesystem.h b/lib/include/duckdb/web/io/web_filesystem.h
@@ -132,7 +132,7 @@ class WebFileSystem : public duckdb::FileSystem {
        public:
         /// Constructor
         WebFileHandle(std::shared_ptr<WebFile> file)
-            : duckdb::FileHandle(file->GetFileSystem(), file->GetFileName(), FileOpenFlags(1)),
+            : duckdb::FileHandle(file->GetFileSystem(), file->GetFileName(), FileOpenFlags::FILE_FLAGS_READ),
               file_(file),
               readahead_(nullptr),
               position_(0) {

diff --git a/lib/src/io/buffered_filesystem.cc b/lib/src/io/buffered_filesystem.cc
@@ -42,7 +42,7 @@ void BufferedFileHandle::Close() { file_ref_->Release(); }
 /// Constructor
 BufferedFileHandle::BufferedFileHandle(duckdb::FileSystem &file_system,
                                        std::shared_ptr<FilePageBuffer::FileRef> file_buffers)
-    : duckdb::FileHandle(file_system, std::string{file_buffers->GetPath()}, FileOpenFlags(1)),
+    : duckdb::FileHandle(file_system, std::string{file_buffers->GetPath()}, FileOpenFlags::FILE_FLAGS_READ),
       file_ref_(std::move(file_buffers)),
       file_position_(0) {}
 

diff --git a/lib/src/io/memory_filesystem.cc b/lib/src/io/memory_filesystem.cc
@@ -17,7 +17,7 @@ MemoryFileSystem::FileBuffer::FileBuffer(size_t id, std::string path, std::vecto
     : file_id(id), file_path(std::move(path)), buffer(std::move(buffer)), handles() {}
 /// Constructor
 MemoryFileSystem::FileHandle::FileHandle(MemoryFileSystem &file_system, FileBuffer &buffer, size_t position)
-    : duckdb::FileHandle(file_system, buffer.file_path, FileOpenFlags(1)),
+    : duckdb::FileHandle(file_system, buffer.file_path, FileFlags::FILE_FLAGS_WRITE | FileFlags::FILE_FLAGS_FILE_CREATE),
       file_system_(file_system),
       buffer_(buffer),
       position_(position) {}