Create windows Dockerfile generator and add images #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a powershell script to generate the Windows Dockerfiles and adds some additional images (including a fix for #236). To generate the Windows Dockerfiles, you can run: .\windows-assets\generate-windows-files.ps1 -MavenVersion '3.9.0' -MavenHash 'THEHASHFORMAVEN.ZIP' This will generate the directories, Dockerfiles and github action templates for the items defined in windows-image-configs.json.
|
Looks like ltsc2022 isn't supported on GH Actions |
|
I don't have access to a windows box so it's going to be hard for me to support this setup |
|
I guess a shell script would be better then? |
|
yeah for the generation definitely I'm moving the linux images to use one main image to build and use I have some work in progress that will push soon. |
|
Ok, I'll wait and see what it looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a powershell script to generate the Windows Dockerfiles and adds some additional images (including a fix for #236). To generate the Windows Dockerfiles, you can run:
.\windows-assets\generate-windows-files.ps1 -MavenVersion '3.9.0' -MavenHash 'THEHASHFORMAVEN.ZIP'
This will generate the directories, Dockerfiles and github action templates for the items defined in windows-image-configs.json.