forked from cnabio/cnab-go
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pin golang.org/x/sys to fix windows compilation
Upstream golang.org/x/sys introduced a breaking change within a major version, see golang/go#34610. The workaround is to pin it to the last revesion that is compatible with the version of moby/moby that we are using. Verify that the code compiles on windows, macos and linux during our CI run to catch problems like this one (a regression in golang.org/x/sys) in the future as soon as it happens. Also do a reset of our go dependencies after bootstrap. When we use go get to install global dependencies, it modifies our go.* files changing the versions of the dependencies that we required, making the build break, because kind requires different versions than docker. This resets it back to what we need before we compile. Signed-off-by: Carolyn Van Slyck <[email protected]>
- Loading branch information
1 parent
8b2ff3a
commit ceffcbe
Showing
5 changed files
with
23 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ steps: | |
| go version | ||
| go get sigs.k8s.io/[email protected] | ||
| make bootstrap build lint coverage | ||
| GOOS=windows make build | ||
| GOOS=darwin make build | ||
| workingDirectory: '$(modulePath)' | ||
| displayName: 'Get dependencies, build, test' | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters