v1.7.0 with deprecation warnings #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create function `distinct_emoji_list()` * Deprecation warnings for: * the old dicts `EMOJI_UNICODE_*, UNICODE_EMOJI_*` * some `language` parameters, that don't have an effect * `emoji.get_emoji_regexp` method: suggestions is to use `replace_emoji()` instead * `use_alias` parameter: suggestion is to use `language='alias'` * `emoji.emoji_lis()`: suggestion is to use `emoji_list()` * `emoji.distinct_emoji_lis()`: suggestion is to use `distinct_emoji_list()`
|
@cvzi Thank you for your PR. Sorry for the merge delay ((( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
emoji_list()distinct_emoji_list()EMOJI_UNICODE_*, UNICODE_EMOJI_*, ...languageparameters, that don't have an effectemoji.get_emoji_regexp()method: suggestion in the warning is to usereplace_emoji()insteaduse_aliasparameter: suggestion in the warning is to uselanguage='alias'emoji.distinct_emoji_lis(): suggestion is to usedistinct_emoji_list()emoji.emoji_lis(): suggestion is to useemoji_list().The warnings look like this:
In Python 3.7, 3.8, 3.9, 3.10 the deprecation warnings are shown by default if one of the functions/variables is used.
In Python 2.7, 3.4, 3.5, 3.6 the deprecation warnings are not shown by default, you would need to enable all warnings with
python -W all file.pyto see them.Also in these older version the warning for module variables e.g.
emoji.EMOJI_UNICODE_*don't work.I don't think that is problem, someone who is still using an old Python version is probably not going to just update this package without testing it.