forked from microsoft/AzUrlShortener
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge vnext #1
Open
DavidTCarpenters
wants to merge
20
commits into
carpentersgroup:vnext
Choose a base branch
from
mreyeros:merge-vnext
base: vnext
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge vnext #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidTCarpenters
commented
Jul 30, 2021
- Introduced Blazored.FluentValidation for handling Validation of ShortUrlEntity on Edits or Adds
- Introduced IStorageTableHelper to inject StorageTableHelper via Dependency Injection for all Azure Functions removing code duplication
- Modified ShortUrlEntity Clicks definition from int to Dictionary<string, int> to store click counts by country
- Intriduced some helpers and extensions methods to reduce code duplication
- Introduced EntityJsonPropertyConverter to handle serialization/deserialization of ShortUrlEntity Clicks property
- Introduced UserIpLocationService to call the https://freegeoip.app/ service for obtaining user click data (i.e. country of origin)
- Updated all azure functions to inject IStorageTableHelper to reduce code duplication and coupling to StorageTableHelper implementation
- adding ip location support - code refactoring/cleanup
…factoring - Introduced Blazored.FluentValidation for handling Validation of ShortUrlEntity on Edits or Adds - Introduced IStorageTableHelper to inject StorageTableHelper via Dependency Injection for all Azure Functions removing code duplication - Modified ShortUrlEntity Clicks definition from int to Dictionary<string, int> to store click counts by country - Intriduced some helpers and extensions methods to reduce code duplication - Introduced EntityJsonPropertyConverter to handle serialization/deserialization of ShortUrlEntity Clicks property - Introduced UserIpLocationService to call the https://freegeoip.app/ service for obtaining user click data (i.e. country of origin) - Updated all azure functions to inject IStorageTableHelper to reduce code duplication and coupling to StorageTableHelper implementation
related to issue microsoft#319
Ref to Issue microsoft#320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.