Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming directories. #229

Merged

Conversation

reid-a
Copy link
Contributor

@reid-a reid-a commented Sep 23, 2020

This commit does the directory-renaming part of issue #226, but
retains the sequential integer prefix for the episode file names.

Modifying or removing the numerical prefix involves changes to
the style code (so tests will still work), and possibly interacting
with the upstream Carpentries repo, which I feel should be
separated from the directory issue.

This commit does the directory-renaming part of issue carpentries-incubator#226, but
retains the sequential integer prefix for the episode file names.

Modifying or removing the numerical prefix involves changes to
the style code (so tests will still work), and possibly interacting
with the upstream Carpentries repo, which I feel should be
separated from the directory issue.
Copy link
Contributor

@psteinb psteinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reid-a reid-a merged commit 76f6312 into carpentries-incubator:gh-pages Sep 24, 2020
@reid-a reid-a deleted the issue-226-rename-subdirectories branch September 24, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants