Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mention of bash in Episode 11 #365

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

cbohn4
Copy link
Contributor

@cbohn4 cbohn4 commented Jul 26, 2021

The lesson's key points are correct and match the lesson's content. I believe bash should be removed from the key points since it was not used in the specific episode. For a brief introduction, it would be best to keep it as a simple difference between CLI and GUI until bash is needed in later episodes' examples when running different jobs.

For the key points review in #116

Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM. Approved, pending CI checks.

@annajiat annajiat merged commit 6e4f8a2 into carpentries-incubator:gh-pages Aug 18, 2021
@annajiat annajiat self-assigned this Aug 18, 2021
Copy link
Contributor

@annajiat annajiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants