Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change website elements to a different language #544

Closed
joelnitta opened this issue Nov 21, 2023 · 2 comments · Fixed by #546
Closed

Cannot change website elements to a different language #544

joelnitta opened this issue Nov 21, 2023 · 2 comments · Fixed by #546
Labels
duplicate This issue or pull request already exists enhancement New feature or request frequency: high indicator that a use-case has a high-frequency in lessons help wanted Extra attention is needed refactor 😰 This feature will need a significant amount of refactoring

Comments

@joelnitta
Copy link
Contributor

Please briefly describe your problem and what output you expect:

There seems to be no way to change website elements like “Summary and Setup” and “Summary and Schedule”. The lang: field in config.yaml gives this impression, but AFAICT it doesn't do anything. I would like to be able to change these so that I can render a lesson in a language other than English (example: git-novice in Japanese).

@zkamvar
Copy link
Contributor

zkamvar commented Nov 21, 2023

Hi Joel, see #205 for details. In essence, there is machinery to implement this change, but it's going to take some effort (I spent some time documenting my own efforts, but it's going to take a lot more work). This was something that I had planned to work on after the lesson transition effort, but priorities were shifted away for me.

@zkamvar zkamvar added duplicate This issue or pull request already exists enhancement New feature or request help wanted Extra attention is needed refactor 😰 This feature will need a significant amount of refactoring frequency: high indicator that a use-case has a high-frequency in lessons labels Nov 21, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Nov 21, 2023

The lang: field in config.yaml is a bit of a hopeful placeholder that I added during the transition in anticipation of #205 being addressed.

avallecam added a commit to avallecam/workbench-spanish that referenced this issue Nov 28, 2023
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this issue Nov 28, 2023
Auto-generated via {sandpaper}
Source  : f8f9362
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2023-11-28 10:27:45 +0000
Message : add lang es in config yaml

as in carpentries/sandpaper#544
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this issue Nov 28, 2023
Auto-generated via {sandpaper}
Source  : c9f8c2b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-28 10:29:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f8f9362
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2023-11-28 10:27:45 +0000
Message : add lang es in config yaml

as in carpentries/sandpaper#544
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this issue Nov 28, 2023
Auto-generated via {sandpaper}
Source  : c9f8c2b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-28 10:29:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f8f9362
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2023-11-28 10:27:45 +0000
Message : add lang es in config yaml

as in carpentries/sandpaper#544
@zkamvar zkamvar linked a pull request Dec 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request frequency: high indicator that a use-case has a high-frequency in lessons help wanted Extra attention is needed refactor 😰 This feature will need a significant amount of refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants