ensure country codes; small refactor of translation strings #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem with the testing which reveals a bit of a fragile relationship between the translations and the rest of the varnish data. Likely the translations need to be set during the build time and kept as a permanent fixutre.
One of the problems that lead me to 7d9cc2c was the fact that a test for `build_lesson()` was failing in the situation where we removed the instructor notes page from the source and rebuilt it using the instructor note aggregator function without the `build_lesson()` context. When `this_lesson()` was called, it clobbered the `$translation` items and then we got an error in that test because the translation for the title was not available. I will reiterate that this problem is almost non-existent because none of the HTML generating functions are exported nor are they called directly by users, but it still bothers me. In fact, it would be a good idea to centralise the translation to a single function and always assume that the global data will always exist. This would help avoid confusing errors in the language of the lesson (as opposed to the language of the user).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that codes like
es_ARcan be used.It also starts a refactor where the translations for generated pages are not duplicated across files.