Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a link to review and/or DOI in the banner for Lab lessons #67

Closed
tobyhodges opened this issue Aug 31, 2023 · 3 comments · Fixed by carpentries/sandpaper#535
Closed
Labels
enhancement New feature or request {sandpaper} user interface package {varnish} HTML/CSS/JS templates

Comments

@tobyhodges
Copy link
Member

It would be nice to re-introduce the celebration of a lesson passing peer review that was displayed as a banner in styles:

Screenshot of the top of the Carpentries Lab lesson: Metagenomics Workshop Overview

In a Workbench lesson, I think this could be a message in the same space as the life cycle stage is currently displayed. I guess this means adding templating for this into sandpaper and maybe also defining styling in varnish, but I need a bit more time to explore before I can be certain.

@zkamvar if you and the other maintainers are happy with the suggestion feel free to assign this one to me.

@zkamvar
Copy link
Contributor

zkamvar commented Aug 31, 2023

Related: carpentries/varnish#40

The best way to prototype this is to open up https://carpentries-incubator.github.io/good-enough-practices/, right click on the top of the lesson and open the inspector in your browser.

From there, you can play around with inserting text into the top bar.

This is what I've come up with using the bootstrap badging class:

header with all elements

doi badge

<abbr class="badge badge-light" title="This lesson has been peer-reviewed">
  <a href="https://cdh.carpentries.org/the-lesson-life-cycle.html#polishing-beta-stage" class="external-link alert-link" style="color: #383838;">
    <i aria-hidden="true" class="icon" data-feather="user-check" style="color: #FF4955; border-radius: 5px"></i>
    &nbsp; doi: XX.XXXXX
  </a>
  <span class="visually-hidden">This lesson has been peer reviewed</span>
</abbr>

@tobyhodges
Copy link
Member Author

Ah, thanks for the breadcrumbs to old discussions that I had forgotten about altogether 😅 This is very helpful advice: I will begin working something up in the coming days.

@zkamvar zkamvar added enhancement New feature or request {sandpaper} user interface package {varnish} HTML/CSS/JS templates labels Aug 31, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Aug 31, 2023

To be fair, it took me a while to find the right issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request {sandpaper} user interface package {varnish} HTML/CSS/JS templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants