Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lesson from beta #124

Closed
ewallace opened this issue Aug 31, 2023 · 1 comment · Fixed by #128
Closed

Update lesson from beta #124

ewallace opened this issue Aug 31, 2023 · 1 comment · Fixed by #128
Assignees
@ewallace

Comments

@ewallace
Copy link
Collaborator

Peer review means that this lesson is no longer in beta. We should update this along with porting to Carpentries lab.

@tobyhodges I'll put in a pull request to remove beta status, and wait to hear from you about any other steps needed before merging.
@ewallace ewallace self-assigned this Aug 31, 2023
@ewallace ewallace mentioned this issue Aug 31, 2023
Closed
@tobyhodges
Copy link
Member

tobyhodges commented Aug 31, 2023 •
edited
Loading

Great to see that the transition to the Workbench has taken place. Thanks @zkamvar for your help. Updating the life cycle stage was one of the modifications to the config.yaml file I mentioned in carpentries-lab/reviews#24 (comment)

The others are:

  • carpentry should be changed from incubator to lab
  • source should be changed to point to the new repository URL after the transfer to carpentries-lab organisation has been completed

In the old infrastructure we had a nice "this lesson has passed peer review" banner that supported linking to the DOI (see https://carpentries-lab.github.io/python-aos-lesson/ for an example) but this has not yet been implemented in the new layout. I will open an issue on https://github.com/carpentries/workbench and begin working on that. [Edit: here is the issue https://github.com/carpentries/workbench/issues/67]

ewallace added a commit that referenced this issue Aug 31, 2023
@ewallace
Update config.yaml for carpentries lab transition, fixes #124
40d62a9 
- lesson changed to stable status
- carpentry changed from incubator to lab
- source changed to point to the new repository URL (before the transfer to carpentries-lab organisation though)
@ewallace ewallace mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewallace ewallace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update config.yaml for carpentries lab transition carpentries-lab/good-enough-practices
2 participants
@ewallace @tobyhodges