Replace mime-types gem with mini_mime #2292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the MimeTypes gem with MiniMime.
Similar to mikel/mail#1059 and teamcapybara/capybara#1884, this switches out the Mime Types gem with MiniMime to save memory.
EDIT:
There seems to be some requirements around the integration between carrierwave and fog going on here.
I see a couple of options:
mime-types
gem.fog
to move across tomini_mime
as well.With the incredibly popular mail and capybara gems moving to mini_mime, it'd be nice to switch carrierwave across too (or at least provide the option)