Show actual log during custom wait rule if asked specifically #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/kapp/config/config.go
Outdated
| @@ -57,6 +57,7 @@ type WaitRuleConditionMatcher struct { | |||
| SupportsObservedGeneration bool | |||
| UnblockChanges bool | |||
| Timeout string | |||
| ShowActualMessage bool | |||
There was a problem hiding this comment.
nit: ShowActualMessage -> ShouldDisplayActualMessage
There was a problem hiding this comment.
I am ok with anything. However ShouldDisplayActualMessage seems a bit long.
rohitagg2020
force-pushed
the
add-actual-log
branch
2 times, most recently
from
b21758e to
ac0ceea
Compare
praveenrewar
reviewed
Dec 9, 2024
| @@ -131,6 +131,7 @@ func (s CustomWaitingResource) IsDoneApplying() DoneApplyState { | |||
| } | |||
|
|
|||
| unblockChangeMsg := "" | |||
| actualMsg := "No failing or successful conditions found" | |||
There was a problem hiding this comment.
Maybe just message instead of actualMsg?
We are assigning the variable with a custom message which indicated that it is just not "actual" 🤔
Signed-off-by: Rohit Aggarwal <[email protected]>
rohitagg2020
force-pushed
the
add-actual-log
branch
from
ac0ceea to
6daa95f
Compare
praveenrewar
approved these changes
Dec 9, 2024
AkbaraliShaikh
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show actual log during custom wait rule if asked specifically
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: