fix: use proper format for congo phone numbers #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What an awesome package you've put together! I started using this in a project, and came across an incorrect formatting for phone numbers in the Republic of Congo.
Motivation and Context
In order to provide the correct format for a phone input for the Republic of Congo, I had to update the mask in
lib/formatters/phone_input_formatter.dart
. The proper mask should be+000 00 00 00000
. ReferenceChanges Made
Updated the mask to use the proper format.
How to Test
You can use the international code
+242
to start formatting a Congo number.Checklist
Additional Notes
You currently have two failing tests around the formatting of numbers in the Philippines. I didn't want to touch those in this PR though due to separation of concerns, but wanted to mention it.