Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix number will be changed automatically as 89 or 83 #132

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

jonhcbs
Copy link
Contributor

@jonhcbs jonhcbs commented Jun 8, 2023

No description provided.

@caseyryan
Copy link
Owner

  1. The parameter you've added must be "true" by default. Your current solution will break existing functionality where it is used.
  2. Why is this necessary?

@jonhcbs
Copy link
Contributor Author

jonhcbs commented Jul 6, 2023

  1. changed default to true
  2. for example, some one do not want to input +1 prefix of phone number in us, then input 89 or 83, the number will changed to 73 automatically. this is not expected behavior, they do not want it change automatically. and it is not used in rus or aus.

@caseyryan
Copy link
Owner

  1. changed default to true
  2. for example, some one do not want to input +1 prefix of phone number in us, then input 89 or 83, the number will changed to 73 automatically. this is not expected behavior, they do not want it change automatically. and it is not used in rus or aus.

That's a good point. I implemented this behavior when there was no possibility to enter phone numbers without country code. Now it really makes sense

@caseyryan caseyryan closed this Jul 13, 2023
@caseyryan caseyryan reopened this Jul 13, 2023
@caseyryan caseyryan merged commit d43f053 into caseyryan:master Jul 13, 2023
caseyryan added a commit that referenced this pull request Jul 13, 2023
@caseyryan
Copy link
Owner

Your fix is now available in 2.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants