Allows get data in PhoneCodes bypassing caching #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Спасибо! Согласен с решением. Смерджил |
caseyryan
added a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting country datas from PhoneCodes for the profile/settings page. On the same page it was possible to switch locale from English to Russian and vice versa. But because of _allCountryDatas I couldn't get an updated list of countries.
I rebuild the page using Bloc, but any other ways didn't work either. Only if I completely reload the page, which is not suitable.
So I added the isForce argument to bypass unnecessary caching, but I don't really see the point of _countryCodes and _allCountryDatas anyway.