Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mask should work regardless of kDebugMode #142

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Replace mask should work regardless of kDebugMode #142

merged 1 commit into from
Sep 19, 2023

Conversation

kasipavankumar
Copy link
Contributor

Hi, thank you for wonderful package.

The replacePhoneMask method currently does not apply the mask because of the condition which only runs when kDebugMode is true. This PR fixes that behaviour.

@gurgenAya gurgenAya mentioned this pull request Sep 18, 2023
Closed
@caseyryan caseyryan merged commit 9690a13 into caseyryan:master Sep 19, 2023
@caseyryan
Copy link
Owner

Hi! Thank you.
You are right. Merged your PR. The change is available in 2.11.11 now

@kasipavankumar
Copy link
Contributor Author

Hi! Thank you. You are right. Merged your PR. The change is available in 2.11.11 now

Great. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyryan caseyryan caseyryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasipavankumar @caseyryan