-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI builds for iOS 13 are flaking #29
Comments
Based on some testing in #30, it looks like this is specifically caused by bumping the framework's minimum version from iOS 10 to iOS 12. More specifically, the change to the sample app's deployment target is not what caused the flakes, and therefore I do not expect this is an issue that consumers are currently seeing. This means that we need to dig into the root cause of these flakes before moving forward with the 0.4.0 release. |
From #31, it looks like changing the minimum supported iOS version to 11.0 is a viable option. |
My theory for the |
From some debugging in #36, it seems like the problem is in the test target, not the framework itself. I think at this point we're okay to move forward with other PRs and continue with the 0.4 release, since it seems that any other change to the test target will fix the tests. I'm going to go ahead and close this issue for now. If we see more flaky tests on a subsequent PR, let's reopen this and continue investigating. |
The CI build on iOS 13 seems to be flaking on a few specific tests:
This started after bumping the minimum iOS version to 12.0 (#27). I've seen this flake twice now.
The text was updated successfully, but these errors were encountered: