Bump minimum supported iOS version to 12.0 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efirestone
approved these changes
Oct 4, 2020
|
Realized there were a fair number of availability checks for iOS 11 that can be removed now. Addressed in 54c645d. |
NickEntin
force-pushed
the
entin/ios-12-minimum
branch
from
54c645d to
b7faefa
Compare
|
No idea why that CI build had some differences in the iOS 13 snapshots the first time. testTabBars()
- Item B: 3 items. Tab. 2 of 4.
+ Item B. Tab. 2 of 4.
- Item C: A. Tab. 3 of 4.
+ Item C. Tab. 3 of 4.
testStepper()
- Decrement. Button.
+ minus. Button.
- Increment. Button.
+ plus. Button.
testStepperAtMin()
- Decrement. Dimmed. Button.
+ minus. Dimmed. Button.
- Increment. Button.
+ plus. Button.Kicking off a new build fixed it though. Same environment as far as I can tell. And everything seems to be working locally. 🤷♂️ I'm gonna call that a weird flake and move forward with this. I'll keep an eye on it and see if any more fail like this going forward though. |
eliperkins
added a commit
to eliperkins/AccessibilitySnapshot
that referenced
this pull request
Dec 19, 2022
These were leftover from cashapp#27 and are no longer used.
eliperkins
added a commit
to eliperkins/AccessibilitySnapshot
that referenced
this pull request
Dec 19, 2022
These were leftover from cashapp#27 and are no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25.