Include the identifier in the call to FBSnapshotVerifyView for SnapshotVerifyWithInvertedColors #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the SnapshotVerifyWithInvertedColors implementation
kruegermj
force-pushed
the
krueger/inverted-colors-identifier
branch
4 times, most recently
from
d7e2168 to
1910da9
Compare
NickEntin
reviewed
Jan 17, 2024
Comment on lines
+36
to
+37
| override func viewDidLoad() { | ||
| super.viewDidLoad() |
There was a problem hiding this comment.
Why the change to viewDidLoad()? This should mirror the notification center observer removal in viewWillDisappear(_:) below.
There was a problem hiding this comment.
I misunderstood the comment below in the issue. I think we just need to update the status label in viewDidLoad. I made that change and confirmed it is needed to get the label to render in the snapshot.
Due to a view life cycle issue with the snapshot test framework, you'll need to modify where the status get checked in the sample view controller in order to get the initial check to pass. The easiest way to accomplish this is to move the code from viewWillAppear(_:) to the end of viewDidLoad().
this is needed because of a life cycle issue in the test framework
kruegermj
force-pushed
the
krueger/inverted-colors-identifier
branch
from
d995636 to
4ffd48f
Compare
NickEntin
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #51