-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Amount
and remove AmountStr
.
#609
Comments
Amount
there no need to wrap it in the AmoutnStr
. The reason we have to use AmountStr
is for when the Keys response is json serialized it needs to be as a string and not an int, so that's really the only place we should use AmountStr
everywhere else is Amount
.Amount
and remove AmountStr
.
crodas
added a commit
to crodas/cdk
that referenced
this issue
Feb 21, 2025
Fixes cashubtc#609 Instead write a customer serializer for Keys to serialize amounts as strings
crodas
added a commit
to crodas/cdk
that referenced
this issue
Feb 21, 2025
Fixes cashubtc#609 Instead write a customer serializer for Keys to serialize amounts as strings
crodas
added a commit
to crodas/cdk
that referenced
this issue
Feb 21, 2025
Fixes cashubtc#609 Instead write a customer serializer for Keys to serialize amounts as strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EDIT: I see you're creating a
Keys
which currently does expect theAmountStr
cdk/crates/cashu/src/nuts/nut01/mod.rs
Line 63 in e1458b0
AmountStr
type?cc @crodas
Originally posted by @thesimplekid in #605 (comment)
The text was updated successfully, but these errors were encountered: