-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KVAC Mint and Wallet #619
Draft
lollerfirst
wants to merge
91
commits into
cashubtc:main
Choose a base branch
from
lollerfirst:cdk-kvac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,631
−33
Draft
KVAC Mint and Wallet #619
Changes from 83 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
261a024
kvac keyset
lollerfirst e93d55a
keysets pt.2
lollerfirst 99b411c
migrations
lollerfirst 9c53bdd
migrations pt2
lollerfirst 8638835
bootstrap
lollerfirst 4ef7f18
separate keysets and keyset methods
lollerfirst 0ee7d66
migration fix
lollerfirst 2d0604a
remove max order from kvac keyset creation
lollerfirst 0b18726
keyset responses
lollerfirst 633de5e
bootstrap request
lollerfirst 79fc2ab
missing doc
lollerfirst c9c60b5
inputs -> outputs
lollerfirst fe81c11
fix typo
lollerfirst cb45798
update cashu-kvac
lollerfirst 24a07fa
fix dependencies
lollerfirst 264aff1
wallet kvac keysets
lollerfirst 726de71
cdk-redb cdk-rexie add missing WalletDb trait methods
lollerfirst 0252b9f
default trait implementations
lollerfirst ca79ff9
fix botched migration
lollerfirst 8f01d84
more bootstrap related changes
lollerfirst 70974ca
complete bootstrap logic
lollerfirst 3ae0cbb
default impl for unimplemented kvac traits
lollerfirst 28e82a3
working bootstrap request
lollerfirst 81b6881
update cashu-kvac + script should be a String
lollerfirst 44d0bbc
bump cashu-kvac
lollerfirst 707cdd6
remove dummy kvac methods implementations from redb crate
lollerfirst 7b66a87
start swap impl
lollerfirst 42cc0e8
mint swap complete
lollerfirst 3182975
swap request and database methods
lollerfirst d47473d
connect to route handler
lollerfirst 46e6371
fixes
lollerfirst 00dc54a
implement add_kvac_issued_macs
lollerfirst feed058
wallet swap
lollerfirst 747acf5
clearer comments
lollerfirst c8bc9e4
kvac send wallet side
lollerfirst 50a6912
fixes
lollerfirst 82cc0d6
working ✅
lollerfirst d282021
cashu-kvac version bump
lollerfirst 0f99a44
bump cashu-kvac
lollerfirst 8d85b05
change tracing output for `process_kvac_swap_request` + cargo fmt
lollerfirst 8e5fbf1
Merge remote-tracking branch 'upstream/main' into cdk-kvac
lollerfirst 7bc4fef
post merge fixups
lollerfirst 852bccc
kvac mint request + unified kvac verification
lollerfirst f46e4ab
wallet mint request ✅
lollerfirst 187b193
make example interesting
lollerfirst 8ec761b
kvac melt request
lollerfirst ac01c1b
fix route
lollerfirst 50d2ecc
fix utoipa paths reques types
lollerfirst 15fb341
wallet melt working ✅
lollerfirst 0fba4c6
update kvac wallet example
lollerfirst 970ad5f
bump cashu-kvac
lollerfirst d6afff3
update melt fee return tweaking
lollerfirst 11712e0
Merge remote-tracking branch 'upstream/main' into cdk-kvac
lollerfirst 20e707b
fix error code
lollerfirst 2735526
Merge remote-tracking branch 'upstream/main' into cdk-kvac
lollerfirst 08b545c
bump cashu-kvac
lollerfirst 6babe65
adjust verification process
lollerfirst 4608593
kvac restore + cargo fmt
lollerfirst 7ce9925
checkstate
lollerfirst 5fa5913
comment out restore.rs
lollerfirst 61d070e
Merge remote-tracking branch 'upstream/main' into cdk-kvac
lollerfirst 835fced
Merge remote-tracking branch 'upstream/main' into cdk-kvac
lollerfirst e99faed
post-merge fix
lollerfirst 4e9b553
wallet checkstate
lollerfirst 63a7ab9
cargo fmt
lollerfirst 56946bc
wallet restore
lollerfirst 8a6cc8e
cargo fmt
lollerfirst 60c4286
test restore with example
lollerfirst 9cfec5c
wallet restore + state checks + fix bug not committing tx in db
lollerfirst 8725cc5
simply import
lollerfirst 2730f53
cargo fmt
lollerfirst dd6ab0f
clippy pt.1
lollerfirst 39a2561
cargo clippy pt.2
lollerfirst e5e1d64
rename kvac wallet example
lollerfirst fc69140
receive into wallet
lollerfirst 95b8397
receive exaple
lollerfirst a43784e
correctly reset nullifiers states after failed spent check
lollerfirst 5e9b886
dedicated verification module
lollerfirst 644a070
break down and isolate verification steps
lollerfirst f760624
cargo fmt
lollerfirst 3757caf
cargo +nightly fmt
lollerfirst 26f9f3e
cargo clippy
lollerfirst 2a22bc3
fix
lollerfirst cbeb3ca
mod issuance
lollerfirst 14f2e2e
isolate kvac errors
lollerfirst 3634b9d
fix keyset id generation
lollerfirst d3c12af
update cargo.toml s gated kvac feature
lollerfirst a41e094
gate all kvac stuff behind "kvac" feature
lollerfirst d6e5fe4
clarification comments
lollerfirst 1346944
fix comment
lollerfirst 41f6006
apply `kvac` feature to v2 kvac router
lollerfirst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To include the KVAC dependency
cashu_kvac
only when thekvac
feature is enabled, you'd have to do two things:First, specify the
kvac
feature should pull in the dependency:Second, add an
optional = true
to thecashu_kvac
dependency below, similar for example toutoipa
. This will mean the dependency should not be included, unless an activated feature explicitly needs it.