Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db check on delete proofs #630

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Mar 5, 2025

Description


closes #627

Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

@thesimplekid thesimplekid force-pushed the db_check_on_delete_proofs branch from 7a3b993 to 8a03676 Compare March 5, 2025 20:09
@ok300
Copy link
Contributor

ok300 commented Mar 5, 2025

Also a NIT: the new redb and sqlite tests look essentially the same (except for the DB instance), so maybe they should be extracted out to a common place and called with a DB instance arg?

@thesimplekid thesimplekid force-pushed the db_check_on_delete_proofs branch from 7eb1cc6 to 1cd5830 Compare March 6, 2025 09:22
@thesimplekid
Copy link
Collaborator Author

Also a NIT: the new redb and sqlite tests look essentially the same (except for the DB instance), so maybe they should be extracted out to a common place and called with a DB instance arg?

Thats a good point. Since this is just these two tests I'm going to leave it as is for now but we should come back to that and create more complete tests specific to the DB. I opened an issue for tracking feel free to add ideas to that #632.

@thesimplekid thesimplekid merged commit 393c95e into cashubtc:main Mar 6, 2025
63 checks passed
@thesimplekid thesimplekid deleted the db_check_on_delete_proofs branch March 10, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localstore.remove_proofs should select for only pending proofs
2 participants