Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify process_swap_request #631

Merged

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Mar 5, 2025

Description

This PR slightly changes the process_swap_request implementation: it validates if the tx is balanced before storing the new proofs in the DB. By doing this, we avoid having to later remove these proofs in case the tx is not balanced.


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

  • NUT-17: Removed superfluous proof state notification

Checklist

@thesimplekid
Copy link
Collaborator

Since we now expect it to fail at the unbalanced check we should change this error

cdk::Error::TokenAlreadySpent => (),

@ok300 ok300 marked this pull request as ready for review March 6, 2025 10:24
@ok300 ok300 marked this pull request as draft March 6, 2025 10:26
@ok300 ok300 marked this pull request as ready for review March 6, 2025 12:37
@thesimplekid thesimplekid merged commit 5a7362c into cashubtc:main Mar 6, 2025
63 checks passed
@ok300 ok300 deleted the ok300-simplify-process_swap_request branch March 6, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants