feat: Add migration for keyset_id as foreign key in SQLite database #634
+122
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
force-pushed
the
keyset_foreign_key
branch
from
59ed409 to
556c384
Compare
|
cc @ok300 |
thesimplekid
force-pushed
the
keyset_foreign_key
branch
from
556c384 to
b569a46
Compare
ok300
reviewed
Mar 6, 2025
crates/cdk-sqlite/src/mint/migrations/20250306165813_keyset_id_as_foreign_key.sql
Outdated
Show resolved
Hide resolved
| tracing::debug!("Attempting to add known proof. Skipping.... {:?}", err); | ||
| .await; | ||
|
|
||
| if let Err(err) = result { |
There was a problem hiding this comment.
The error matching is becoming quite complex. Instead it, why not change the query to INSERT ON CONFLICT IGNORE or INSERT OR IGNORE? I think that would automatically cover both relevant error types:
- proof is already known (conflict on proof's PK
y) - conflict on FK constraint
We wouldn't know why a proof wasn't inserted, but if that's important, we could 1-2 validation steps before the query (check if proof's PK y is known, check if foreign key is valid).
There was a problem hiding this comment.
Address in c6f3318
I think we still want to error and rollback when there is a fk error
…drop improvements
thesimplekid
force-pushed
the
keyset_foreign_key
branch
from
c6f3318 to
a74e49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #628
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing