NUT-04/05: add amount, unit, request to quotes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callebtc
changed the title
callebtc
requested review from
prusnak,
crodas,
thesimplekid,
elnosh and
Egge21M
|
I think this is very reasonable |
elnosh
approved these changes
Mar 7, 2025
thesimplekid
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mandatory change of NUT-04 and NUT-05 adds new fields to the
MintQuoteResponseandMeltQuoteResponseobjects to make it easier for stateless clients to use the API. Mints should already have these fields available in their database.We (I) wrongfully chose not to provide them back to the clients thinking we're smart and want to save some tiny amount of bandwidth, turns out we weren't so smart after all!
MintQuoteResponseMintQuoteResponsenow contains theamountandunitfor the mint operation that was previously provided by the client in theMintQuoteRequestMeltQuoteResponseMeltQuoteResponsenow contains theunitand therequestfor the melt operation that was previously provided by the client in theMeltQuoteRequestFixes #232
Tracking mint implementations
amount,unit,requestto melt and mint quote responses nutshell#719)