Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#616: Fixed pending payment check on startup #707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjbeery24
Copy link
Contributor

Removed blocking call from ledger startup. Instead added it to a background task that repeats every hour.

…d it to a background task that repeats every hour.
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (23a706d) to head (d1c304f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cashu/mint/ledger.py 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   65.67%   64.57%   -1.11%     
==========================================
  Files          88       88              
  Lines        9513     9533      +20     
==========================================
- Hits         6248     6156      -92     
- Misses       3265     3377     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollerfirst lollerfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hourly" seems pretty arbitrary. would you consider parametrize this and add in the setting?

@lollerfirst
Copy link
Contributor

also seems like test_startup_fakewallet_pending_quote_failure needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants