Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed toolflow files to build in Ubuntu 16.04LTS #140

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

jack-h
Copy link
Member

@jack-h jack-h commented Feb 9, 2021

The requirements.txt file has been updated with the "numpy<1.19". Version 1.18.5was the last to support Python 3.5, which we are using. The newer version causes conflicts. Also castro.py causes constructor error due to python pyyaml updates. This was working with pyyaml version 3.13, but not version 5.1 and above. It suggested that I add "Loader=yaml.Loader" to the yaml.load() function and it no longer breaks - checkout yaml/pyyaml#266.

The requirements.txt file has been updated with the "numpy<1.19". Version 1.18.5was the last to support Python 3.5, which we are using. The newer version causes conflicts. Also castro.py causes constructor error due to python pyyaml updates. This was working with pyyaml version 3.13, but not version 5.1 and above. It suggested that I add "Loader=yaml.Loader" to the yaml.load() function and it no longer breaks - checkout yaml/pyyaml#266.
@jack-h jack-h requested review from AdamI75 and jkocz February 9, 2021 09:19
Copy link
Contributor

@AdamI75 AdamI75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes. We should update requirements.txt to include all the relevant versions, but my thinking is that we can get a student to do that as part of the CASPER ongoing work, if possible.

@AdamI75 AdamI75 merged commit e3f407c into master Feb 9, 2021
@jack-h jack-h deleted the ubuntu16-fixes branch February 9, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants