-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1010] Add Solr instructions for prebuilt Lucene index #1379
[#1010] Add Solr instructions for prebuilt Lucene index #1379
Conversation
8595798
to
5aaaa88
Compare
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
============================================
- Coverage 53.61% 53.42% -0.19%
+ Complexity 825 818 -7
============================================
Files 154 154
Lines 8627 8627
Branches 1224 1224
============================================
- Hits 4625 4609 -16
- Misses 3623 3641 +18
+ Partials 379 377 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, thanks for the PR!
Actually, as I was testing the prebuilt index with |
Looked a bit more into this, turns out my index was not built with the I guess it is worth noting that the prebuilt index should have the |
yup, this should be documented somewhere! |
Also, check out: https://github.com/castorini/anserini/blob/master/.travis.yml#L20 It might be reasonable to do a complete e2e integration test based on this? I mean, travis is running it all the time... just a matter of moving it inside JUnit? |
Actually, I have misunderstood the issue again. 😅 I read more about what Then I was wondering, how come I noticed solrconfig.xml#L785 set the default field of search to a field called I modified this field from |
Do we want to do |
Big oops, I tested my assumption again with a newly built index (without |
Maybe |
#1010