Postpend md5 to prebuilt indexes #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2412 +/- ##
=========================================
Coverage 66.91% 66.92%
Complexity 1410 1410
=========================================
Files 208 208
Lines 12095 12098 +3
Branches 1483 1483
=========================================
+ Hits 8093 8096 +3
Misses 3490 3490
Partials 512 512 ☔ View full report in Codecov by Sentry. |
lintool
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the CACM corpus index's filename to match the contents of the zip and stay consistent with all the other indexes.
PrebuiltIndexHandler.javanow renames decompressed prebuilt indexes so that they have their md5 checksums postpended to their directory names (eg.lucene-index.msmarco-v1-passage-splade-pp-ed.20230524.a59610.4b3c969033cbd017306df42ce134c395)