Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MS MARCO V2.1 repo experiments on segmented doc collection #2483

Merged
merged 1 commit into from
May 2, 2024

Conversation

lintool
Copy link
Member

@lintool lintool commented May 2, 2024

Proposed fix to #2480 (comment)

The issue is that '#' may get interpreted as a comment; WSL and Mac might also different on how interpolation, escaping, etc. is handled with ProcessBuilder. This works on my Mac.

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.43%. Comparing base (03b2ce9) to head (dc71934).
Report is 2 commits behind head on master.

Files Patch % Lines
src/main/java/io/anserini/reproduce/RunRepro.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2483      +/-   ##
============================================
+ Coverage     66.41%   66.43%   +0.01%     
- Complexity     1423     1424       +1     
============================================
  Files           215      215              
  Lines         12361    12367       +6     
  Branches       1503     1504       +1     
============================================
+ Hits           8210     8216       +6     
  Misses         3632     3632              
  Partials        519      519              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool requested review from ronakice and MXueguang May 2, 2024 02:04
@lintool
Copy link
Member Author

lintool commented May 2, 2024

This works on both Linux and Mac, so merging in. We can get someone to check Windows via WSL later.

@lintool lintool merged commit 3abc2a0 into master May 2, 2024
3 checks passed
@lintool lintool deleted the repro-fix branch May 2, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants