Replication logs for Robost04 and Core18 #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
============================================
- Coverage 39.61% 39.59% -0.02%
+ Complexity 510 509 -1
============================================
Files 121 121
Lines 7326 7326
Branches 1094 1094
============================================
- Hits 2902 2901 -1
Misses 4135 4135
- Partials 289 290 +1
Continue to review full report at Codecov.
|
lintool
reviewed
Jan 27, 2020
docs/elastirini.md
Outdated
| @@ -76,6 +76,8 @@ sh target/appassembler/bin/IndexCollection -collection JsonCollection -generator | |||
| -es -es.index msmarco-passage -threads 9 -input /path/to/msmarco-passage -storePositions -storeDocvectors -storeRawDocs | |||
| ``` | |||
|
|
|||
| We may need to wait a few minutes after indexing for the index to catch up before performing retrievals, otherwise wrong evaluation metrics are returned. | |||
There was a problem hiding this comment.
Updated, also lumped in some other replication logs in here too
edwinzhng
changed the title
|
Replicate notes here should be added to template: https://github.com/castorini/anserini/blob/master/src/main/resources/docgen/templates/core18.template Maven build auto-generates .md file. See #974 |
lintool
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a comment about letting the index "catch up"
Will need to rebase with #976 before merging