Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace model caching mechanism #9

Closed
achyudh opened this issue Apr 13, 2019 · 2 comments
Closed

Replace model caching mechanism #9

achyudh opened this issue Apr 13, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@achyudh
Copy link
Member

achyudh commented Apr 13, 2019

Due to intermittent network connectivity in the compute clusters, I have been facing issues when fine-tuning BERT models. In order to avoid this, we should move pre-trained models to hedwig-data and have the driver method load pre-trained models from that location rather than downloading it from AWS.

@achyudh achyudh added the enhancement New feature or request label Apr 13, 2019
@achyudh achyudh self-assigned this Apr 13, 2019
@achyudh
Copy link
Member Author

achyudh commented Apr 13, 2019

Since --model takes in folder paths too, we should remove the corresponding restrictions in bert/args.py

daemon pushed a commit that referenced this issue Nov 1, 2019
*  Integrate BERT into Hedwig (#29)

* Fix package imports

* Update README.md

* Fix bug due to TAR/AR attribute check

* Add BERT models

* Add BERT tokenizer

* Return logits from the model.py

* Remove unused classes in models/bert

* Return logits from the model.py (#12)

* Remove unused classes in models/bert (#13)

* Add initial main file

* Add args for BERT

* Add partial support for BERT

* Initialize training and optimization

* Draft the structure of Trainers for BERT

* Remove duplicate tokenizer

* Add utils

* Move optimization to utils

* Add more structure for trainer

* Refactor the trainer (#15)

* Refactor the trainer

* Add more edits

* Add support for our datasets

* Add evaluator

* Split data4bert module into multiple processors

* Refactor BERT tokenizer

* Integrate BERT into Castor framework (#17)

* Remove unused classes in models/bert

* Split data4bert module into multiple processors

* Refactor BERT tokenizer

* Add multilabel support in BertTrainer

* Add multilabel support in BertEvaluator

* Add get_test_samples method in dataset processors

* Fix args.py for BERT

* Add support for Reuters, IMDB datasets for BERT

* Revert "Integrate BERT into Castor framework (#17)"

This reverts commit e4244ec.

* Fix paths to datasets in dataset classes and args

* Add SST dataset

* Add hedwig-data instructions to README.md

* Fix KimCNN README

* Fix RegLSTM README

* Fix typos in README

* Remove trec_eval from README

* Add tensorboardX to requirements.txt

* Rename processors module to bert_processors

* Add method to print metrics after training

* Add model check-pointing and early stopping for BERT

* Add logos

* Update README.md

* Fix code comments in classification trainer

* Add support for AAPD, Sogou, AGNews and Yelp2014

* Fix bug that deleted saved models

* Update README for HAN

* Update README for XML-CNN

* Remove redundant TODOs from the READMEs

* Fix logo in README.md

* Update README for Char-CNN

* Fix all the READMEs

* Resolve conflict

* Fix Typos

* Re-Add SST2 Processor

* Add support for evaluating trained model

* Update args.py

* Resolve issues due to DataParallel wrapper on saved model

* Remove redundant Yelp processor

* Fix bug for safely creating the saving directory

* Change checkpoint paths to timestamps

* Remove unwanted string.strip() from tokenizer

* Create save path if it doesn't exist

* Decouple model checkpoints from code

* Remove model choice restrictions for BERT

* Remove model/distill driver

* Simplify checkpoint directory creation

* Add TREC relevance datasets

* Add relevance transfer trainer and evaluator

* Add re-ranking module

* Add ImbalancedDatasetSampler

* Add relevance transfer package

* Fix import in classification trainer

* Remove unwanted args from models/bert

* Fix bug where model wasn't in training mode every epoch

* Add Robust45 preprocessor for BERT

* Add support for BERT for relevance transfer

* Add hierarchical BERT model

* Remove tensorboardX logging

* Add hierarchical BERT for relevance transfer

* Add learning rate multiplier

* Add lr multiplier for relevance transfer

* Add MLP model

* Add fastText model

* Add Reuters bag-of-words dataset class

* Add input dropout for MLP

* Remove duplicate README files

* Remove model caching mechanism for bert and hbert

Fixes issue #9
@achyudh
Copy link
Member Author

achyudh commented Nov 2, 2019

Fixed in 00f5f99

@achyudh achyudh closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant