Release 0.0.7 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revantark
reviewed
Jan 29, 2024
| AddressP2PKH AddressType = "P2PKH" | ||
| AddressP2SH AddressType = "P2SH" | ||
| AddressP2WPKH AddressType = "P2WPKH" | ||
| AddressSegwit AddressType = "Bech32" |
There was a problem hiding this comment.
AddressSegwit is not being used anywhere and p2wpkh is already a segwit address. Any reason to keep it ?
There was a problem hiding this comment.
AddressSegwit is mostly for future proof and currently is not used anywhere. The whole address file is still experimental. And yeah p2wpkh is a special type address of segwit. Since it is commonly used in a lot places, so it's worth to have a separate type for it, so we know how to how to estimate fees/sign sigature/decode address from key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetNetworkInfo