If no epacems_api_key, return None
instead of throwing an exception
#500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What problem does this address?
Right now if there's no
EPACEMS_API_KEY
set in the environment, an error is thrown whether or not a user is actually archiving EPA CEMS data. This came up in another repository importing thepudl-archiver
code to run an archiver.What did you change in this PR?
Switched from using
os.environ['EPACEMS_API_KEY']
which raises an error if this doesn't exist, toos.environ.get("EPACEMS_API_KEY")
which will returnNone
. This will still fail if the EPA CEMS API key is being called in the archiver, but will allow people to run other archivers without making a fake EPA CEMS API key environment variable.Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list
Tasks