-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook callback for deprecated after_config
callback
#71
Comments
Now that the callback is implemented, it is failing within the hook when creating a new cache when the cache is disabled, such as in the upgrade and install scripts when these two constants are defined: define('CLI_SCRIPT', true);
define('CACHE_DISABLE_ALL', true); Error:
This should be caught in the try/catch block in the hook like in Moodle 4.1 but it is getting caught instead the public static function after_config(\core\hook\after_config $hook) {
try {
global $SESSION, $USER;
// Setup experiment manager.
$manager = new \tool_abconfig_experiment_manager();
...
} catch (Exception $e) { // @codingStandardsIgnoreStart
// Catch exceptions from stuff not existing during installation process, fail silently
} // @codingStandardsIgnoreEnd
} |
Above issue is resolved - see https://stackoverflow.com/questions/39234250/try-catch-is-ignored-in-moodle-php-when-using-httpful-within-a-class |
Issue #71: Use new 'after_config' hook for Moodle 4.5
When installing the plugin on Moodle 4.5, the following error occurs:
The text was updated successfully, but these errors were encountered: