Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new api for uploading snippet #146

Closed
wants to merge 20 commits into from

Conversation

catatsuy
Copy link
Owner

@catatsuy catatsuy commented Apr 13, 2024

refs: #148

This pull request primarily focuses on changes related to the Slack API, specifically the transition from using channels to using channel IDs for file uploads. The changes also include the deprecation of the snippet_channel option and the addition of the channel_id option in the configuration. There are also updates to the README.md file to reflect these changes, and the addition of the github.com/google/go-cmp dependency in the go.mod file.

Changes in the Slack API:

  • README.md: The documentation was updated to reflect the changes in the Slack API, including the transition from channels to channel IDs for file uploads, and the deprecation of the snippet_channel option. [1] [2] [3]
  • internal/cli/cli.go: The code was updated to use channel IDs instead of channels for file uploads. This includes changes in the Run and uploadSnippet functions. [1] [2] [3] [4] [5]
  • internal/cli/cli_test.go: The tests were updated to reflect the changes in the Slack API. This includes changes in the TestUploadSnippet function. [1] [2] [3] [4]
  • internal/config/config.go: The configuration was updated to use channel_id instead of snippet_channel. This includes changes in the Config struct, the LoadEnv and LoadTOML functions, and the slackConfig struct. [1] [2] [3] [4]
  • internal/config/config_test.go: The tests were updated to reflect the changes in the configuration. This includes changes in the TestLoadTOML and TestLoadEnv functions. [1] [2] [3] [4] [5] [6]
  • internal/config/testdata/config.toml: The configuration file was updated to use channel_id instead of snippet_channel.

Changes in dependencies:

  • go.mod: The github.com/google/go-cmp dependency was added.

@catatsuy catatsuy force-pushed the feature_use_new_api_external_url branch from 36e85f3 to 342b854 Compare April 14, 2024 10:32
@catatsuy catatsuy force-pushed the feature_use_new_api_external_url branch from c05861e to 6269785 Compare April 20, 2024 09:06
@catatsuy catatsuy marked this pull request as ready for review April 21, 2024 08:30
@catatsuy catatsuy changed the base branch from master to feature_refactor_token_on_client April 27, 2024 07:04
Base automatically changed from feature_refactor_token_on_client to master April 27, 2024 07:10
@catatsuy catatsuy closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant