-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new api for uploading snippet #146
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36e85f3
to
342b854
Compare
c05861e
to
6269785
Compare
…nnel ID variable name in README and config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #148
This pull request primarily focuses on changes related to the Slack API, specifically the transition from using channels to using channel IDs for file uploads. The changes also include the deprecation of the
snippet_channel
option and the addition of thechannel_id
option in the configuration. There are also updates to theREADME.md
file to reflect these changes, and the addition of thejackfan.us.kg/google/go-cmp
dependency in thego.mod
file.Changes in the Slack API:
README.md
: The documentation was updated to reflect the changes in the Slack API, including the transition from channels to channel IDs for file uploads, and the deprecation of thesnippet_channel
option. [1] [2] [3]internal/cli/cli.go
: The code was updated to use channel IDs instead of channels for file uploads. This includes changes in theRun
anduploadSnippet
functions. [1] [2] [3] [4] [5]internal/cli/cli_test.go
: The tests were updated to reflect the changes in the Slack API. This includes changes in theTestUploadSnippet
function. [1] [2] [3] [4]internal/config/config.go
: The configuration was updated to usechannel_id
instead ofsnippet_channel
. This includes changes in theConfig
struct, theLoadEnv
andLoadTOML
functions, and theslackConfig
struct. [1] [2] [3] [4]internal/config/config_test.go
: The tests were updated to reflect the changes in the configuration. This includes changes in theTestLoadTOML
andTestLoadEnv
functions. [1] [2] [3] [4] [5] [6]internal/config/testdata/config.toml
: The configuration file was updated to usechannel_id
instead ofsnippet_channel
.Changes in dependencies:
go.mod
: Thejackfan.us.kg/google/go-cmp
dependency was added.