Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new api for uploading file #152

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

catatsuy
Copy link
Owner

@catatsuy catatsuy commented Apr 27, 2024

refs: #148

This pull request introduces significant changes to the Slack API implementation, including updates to the file upload process and changes to the command line interface (CLI) and configuration files. The most important changes are the deprecation of the files.upload API, the introduction of new APIs for file uploads, and the replacement of the channel parameter with channel-id for file uploads.

API Changes:

  • CHANGELOG.md: The files.upload API is now deprecated and replaced with files.getUploadURLExternal and files.completeUploadExternal. The channel parameter for file uploads has been replaced with channel-id. The -filetype option has been modified and replaced with -snippet-type.

CLI Changes:

  • internal/cli/cli.go: The channel parameter in the CLI has been replaced with channel-id. The -filetype option has been marked as compatible and replaced with -snippet-type. The uploadSnippet function now requires a channel-id and snippet-type instead of a channel and filetype. [1] [2] [3] [4]

Configuration Changes:

  • README.md, internal/config/config.go, internal/config/config_test.go: The configuration files and tests have been updated to replace the channel parameter with channel-id. The NOTIFY_SLACK_SNIPPET_CHANNEL environment variable and the snippet_channel option in the TOML configuration file have been deprecated. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Test Updates:

  • internal/cli/cli_test.go and internal/config/config_test.go: The tests have been updated to reflect the changes in the CLI and configuration files. The channel parameter has been replaced with channel-id and the -filetype option has been replaced with -snippet-type. [1] [2] [3] [4] [5] [6] F93271deL112R99)

@catatsuy catatsuy merged commit cf17b0b into master Apr 27, 2024
5 checks passed
@catatsuy catatsuy deleted the feature_use_new_api_for_uploading_file branch April 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant