Update NewCLI to receive isStdinTerminal parameter #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on modifying the terminal check in the
notify_slack
command-line interface (CLI). The changes include importing theterm
package inmain.go
, removing the import incli.go
, adding a new member to theCLI
struct, and updating theNewCLI
function and the terminal check inRun
method. The test incli_test.go
was also updated to reflect these changes.Here are the most significant changes:
Changes in
cmd/notify_slack/main.go
:term
package and updated theNewCLI
function call to include a terminal check. This change moves the terminal check from theRun
method incli.go
tomain.go
.Changes in
internal/cli/cli.go
:term
package import. This import is no longer needed here as the terminal check has been moved tomain.go
.isStdinTerminal
to theCLI
struct and updated theNewCLI
function to accept this new member. This allows the terminal check result to be passed into theCLI
struct.Run
method to use the newisStdinTerminal
member of theCLI
struct instead of callingterm.IsTerminal
. This change reflects the new design where the terminal check is done inmain.go
.Changes in
internal/cli/cli_test.go
:NewCLI
function call in the test to include a boolean value for the newisStdinTerminal
member. This ensures the test reflects the changes made to theCLI
struct andNewCLI
function.