refactor exec.Start() and don't provide context for callback #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catatsuy
force-pushed
the
feature_change_done_callback
branch
from
fe90587 to
5294c2a
Compare
make exec.Start() functions synchronous callback functions should not be killed by context
catatsuy
force-pushed
the
feature_change_done_callback
branch
from
5294c2a to
4e64a34
Compare
catatsuy
changed the title
catatsuy
force-pushed
the
feature_change_done_callback
branch
from
52d8887 to
e94fbb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make exec.Start() functions synchronous
callback functions should not be killed by context