Skip to content

Commit

Permalink
Fixup missing approvals
Browse files Browse the repository at this point in the history
  • Loading branch information
horenmar committed Jan 5, 2025
1 parent f387caf commit 39703a1
Show file tree
Hide file tree
Showing 18 changed files with 148 additions and 20 deletions.
1 change: 1 addition & 0 deletions tests/SelfTest/Baselines/automake.sw.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Nor would this
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - double
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - float
:test-result: XFAIL #2615 - Throwing in constructor generator fails test case but does not abort
:test-result: PASS #2944 - Stringifying dates before 1970 should not crash
:test-result: XFAIL #748 - captures with unexpected exceptions
:test-result: PASS #809
:test-result: PASS #833
Expand Down
1 change: 1 addition & 0 deletions tests/SelfTest/Baselines/automake.sw.multi.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - double
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - float
:test-result: XFAIL #2615 - Throwing in constructor generator fails test case but does not abort
:test-result: PASS #2944 - Stringifying dates before 1970 should not crash
:test-result: XFAIL #748 - captures with unexpected exceptions
:test-result: PASS #809
:test-result: PASS #833
Expand Down
8 changes: 6 additions & 2 deletions tests/SelfTest/Baselines/compact.sw.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smalle
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.0f is within 2 ULPs of -1.40129846e-45f ([-4.20389539e-45, 1.40129846e-45])
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
Generators.tests.cpp:<line number>: failed: unexpected exception with message: 'failure to init'
ToString.tests.cpp:<line number>: passed: converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}"
==
"{iso8601-timestamp}"
ToString.tests.cpp:<line number>: passed: converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42'; expression was: thisThrows() with 1 message: 'expected exception'
Exception.tests.cpp:<line number>: passed: thisThrows() with 1 message: 'answer := 42'
Expand Down Expand Up @@ -2854,7 +2858,7 @@ InternalBenchmark.tests.cpp:<line number>: passed: med == 18. for: 18.0 == 18.0
InternalBenchmark.tests.cpp:<line number>: passed: q3 == 23. for: 23.0 == 23.0
Misc.tests.cpp:<line number>: passed:
Misc.tests.cpp:<line number>: passed:
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected


8 changes: 6 additions & 2 deletions tests/SelfTest/Baselines/compact.sw.multi.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smalle
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.0f is within 2 ULPs of -1.40129846e-45f ([-4.20389539e-45, 1.40129846e-45])
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
Generators.tests.cpp:<line number>: failed: unexpected exception with message: 'failure to init'
ToString.tests.cpp:<line number>: passed: converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}"
==
"{iso8601-timestamp}"
ToString.tests.cpp:<line number>: passed: converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42'; expression was: thisThrows() with 1 message: 'expected exception'
Exception.tests.cpp:<line number>: passed: thisThrows() with 1 message: 'answer := 42'
Expand Down Expand Up @@ -2843,7 +2847,7 @@ InternalBenchmark.tests.cpp:<line number>: passed: med == 18. for: 18.0 == 18.0
InternalBenchmark.tests.cpp:<line number>: passed: q3 == 23. for: 23.0 == 23.0
Misc.tests.cpp:<line number>: passed:
Misc.tests.cpp:<line number>: passed:
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected


4 changes: 2 additions & 2 deletions tests/SelfTest/Baselines/console.std.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1610,6 +1610,6 @@ due to unexpected exception with message:
Why would you throw a std::string?

===============================================================================
test cases: 419 | 327 passed | 71 failed | 7 skipped | 14 failed as expected
assertions: 2252 | 2087 passed | 130 failed | 35 failed as expected
test cases: 420 | 328 passed | 71 failed | 7 skipped | 14 failed as expected
assertions: 2254 | 2089 passed | 130 failed | 35 failed as expected

24 changes: 22 additions & 2 deletions tests/SelfTest/Baselines/console.sw.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,26 @@ Generators.tests.cpp:<line number>: FAILED:
due to unexpected exception with message:
failure to init

-------------------------------------------------------------------------------
#2944 - Stringifying dates before 1970 should not crash
-------------------------------------------------------------------------------
ToString.tests.cpp:<line number>
...............................................................................

ToString.tests.cpp:<line number>: PASSED:
REQUIRE( converted_post == "{iso8601-timestamp}" )
with expansion:
"{iso8601-timestamp}"
==
"{iso8601-timestamp}"

ToString.tests.cpp:<line number>: PASSED:
REQUIRE_THAT( converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) )
with expansion:
"{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime
from provided timepoint has failed. This happens e.g. with pre-1970 dates
using Microsoft libc" )

-------------------------------------------------------------------------------
#748 - captures with unexpected exceptions
outside assertions
Expand Down Expand Up @@ -19012,6 +19032,6 @@ Misc.tests.cpp:<line number>
Misc.tests.cpp:<line number>: PASSED:

===============================================================================
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected

24 changes: 22 additions & 2 deletions tests/SelfTest/Baselines/console.sw.multi.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,26 @@ Generators.tests.cpp:<line number>: FAILED:
due to unexpected exception with message:
failure to init

-------------------------------------------------------------------------------
#2944 - Stringifying dates before 1970 should not crash
-------------------------------------------------------------------------------
ToString.tests.cpp:<line number>
...............................................................................

ToString.tests.cpp:<line number>: PASSED:
REQUIRE( converted_post == "{iso8601-timestamp}" )
with expansion:
"{iso8601-timestamp}"
==
"{iso8601-timestamp}"

ToString.tests.cpp:<line number>: PASSED:
REQUIRE_THAT( converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) )
with expansion:
"{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime
from provided timepoint has failed. This happens e.g. with pre-1970 dates
using Microsoft libc" )

-------------------------------------------------------------------------------
#748 - captures with unexpected exceptions
outside assertions
Expand Down Expand Up @@ -19001,6 +19021,6 @@ Misc.tests.cpp:<line number>
Misc.tests.cpp:<line number>: PASSED:

===============================================================================
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected

24 changes: 22 additions & 2 deletions tests/SelfTest/Baselines/console.swa4.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,26 @@ Generators.tests.cpp:<line number>: FAILED:
due to unexpected exception with message:
failure to init

-------------------------------------------------------------------------------
#2944 - Stringifying dates before 1970 should not crash
-------------------------------------------------------------------------------
ToString.tests.cpp:<line number>
...............................................................................

ToString.tests.cpp:<line number>: PASSED:
REQUIRE( converted_post == "{iso8601-timestamp}" )
with expansion:
"{iso8601-timestamp}"
==
"{iso8601-timestamp}"

ToString.tests.cpp:<line number>: PASSED:
REQUIRE_THAT( converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) )
with expansion:
"{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime
from provided timepoint has failed. This happens e.g. with pre-1970 dates
using Microsoft libc" )

-------------------------------------------------------------------------------
#748 - captures with unexpected exceptions
outside assertions
Expand Down Expand Up @@ -951,6 +971,6 @@ Condition.tests.cpp:<line number>: FAILED:
CHECK( true != true )

===============================================================================
test cases: 33 | 27 passed | 3 failed | 3 failed as expected
assertions: 102 | 94 passed | 4 failed | 4 failed as expected
test cases: 34 | 28 passed | 3 failed | 3 failed as expected
assertions: 104 | 96 passed | 4 failed | 4 failed as expected

3 changes: 2 additions & 1 deletion tests/SelfTest/Baselines/junit.sw.approved.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuitesloose text artifact
>
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2281" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2283" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
<properties>
<property name="random-seed" value="1"/>
<property name="filters" value="&quot;*&quot; ~[!nonportable] ~[!benchmark] ~[approvals]"/>
Expand Down Expand Up @@ -59,6 +59,7 @@ failure to init
at Generators.tests.cpp:<line number>
</error>
</testcase>
<testcase classname="<exe-name>.global" name="#2944 - Stringifying dates before 1970 should not crash" time="{duration}" status="run"/>
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions" time="{duration}" status="run"/>
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions/outside assertions" time="{duration}" status="run">
<skipped message="TEST_CASE tagged with !mayfail"/>
Expand Down
3 changes: 2 additions & 1 deletion tests/SelfTest/Baselines/junit.sw.multi.approved.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2281" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2283" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
<properties>
<property name="random-seed" value="1"/>
<property name="filters" value="&quot;*&quot; ~[!nonportable] ~[!benchmark] ~[approvals]"/>
Expand Down Expand Up @@ -58,6 +58,7 @@ failure to init
at Generators.tests.cpp:<line number>
</error>
</testcase>
<testcase classname="<exe-name>.global" name="#2944 - Stringifying dates before 1970 should not crash" time="{duration}" status="run"/>
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions" time="{duration}" status="run"/>
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions/outside assertions" time="{duration}" status="run">
<skipped message="TEST_CASE tagged with !mayfail"/>
Expand Down
1 change: 1 addition & 0 deletions tests/SelfTest/Baselines/sonarqube.sw.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ at AssertionHandler.tests.cpp:<line number>
<testCase name="Parsing tags with non-alphabetical characters is pass-through" duration="{duration}"/>
</file>
<file path="tests/<exe-name>/IntrospectiveTests/ToString.tests.cpp">
<testCase name="#2944 - Stringifying dates before 1970 should not crash" duration="{duration}"/>
<testCase name="Directly creating an EnumInfo" duration="{duration}"/>
<testCase name="Range type with sentinel" duration="{duration}"/>
<testCase name="Stringifying char arrays with statically known sizes - char" duration="{duration}"/>
Expand Down
1 change: 1 addition & 0 deletions tests/SelfTest/Baselines/sonarqube.sw.multi.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,7 @@ at AssertionHandler.tests.cpp:<line number>
<testCase name="Parsing tags with non-alphabetical characters is pass-through" duration="{duration}"/>
</file>
<file path="tests/<exe-name>/IntrospectiveTests/ToString.tests.cpp">
<testCase name="#2944 - Stringifying dates before 1970 should not crash" duration="{duration}"/>
<testCase name="Directly creating an EnumInfo" duration="{duration}"/>
<testCase name="Range type with sentinel" duration="{duration}"/>
<testCase name="Stringifying char arrays with statically known sizes - char" duration="{duration}"/>
Expand Down
6 changes: 5 additions & 1 deletion tests/SelfTest/Baselines/tap.sw.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ ok {test-number} - smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.
ok {test-number} - smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
# #2615 - Throwing in constructor generator fails test case but does not abort
not ok {test-number} - unexpected exception with message: 'failure to init'
# #2944 - Stringifying dates before 1970 should not crash
ok {test-number} - converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}" == "{iso8601-timestamp}"
# #2944 - Stringifying dates before 1970 should not crash
ok {test-number} - converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
# #748 - captures with unexpected exceptions
not ok {test-number} - unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
# #748 - captures with unexpected exceptions
Expand Down Expand Up @@ -4567,5 +4571,5 @@ ok {test-number} - q3 == 23. for: 23.0 == 23.0
ok {test-number} -
# xmlentitycheck
ok {test-number} -
1..2281
1..2283

6 changes: 5 additions & 1 deletion tests/SelfTest/Baselines/tap.sw.multi.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ ok {test-number} - smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.
ok {test-number} - smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
# #2615 - Throwing in constructor generator fails test case but does not abort
not ok {test-number} - unexpected exception with message: 'failure to init'
# #2944 - Stringifying dates before 1970 should not crash
ok {test-number} - converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}" == "{iso8601-timestamp}"
# #2944 - Stringifying dates before 1970 should not crash
ok {test-number} - converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
# #748 - captures with unexpected exceptions
not ok {test-number} - unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
# #748 - captures with unexpected exceptions
Expand Down Expand Up @@ -4556,5 +4560,5 @@ ok {test-number} - q3 == 23. for: 23.0 == 23.0
ok {test-number} -
# xmlentitycheck
ok {test-number} -
1..2281
1..2283

2 changes: 2 additions & 0 deletions tests/SelfTest/Baselines/teamcity.sw.approved.txt
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
##teamcity[testStarted name='#2615 - Throwing in constructor generator fails test case but does not abort']
##teamcity[testIgnored name='#2615 - Throwing in constructor generator fails test case but does not abort' message='Generators.tests.cpp:<line number>|n...............................................................................|n|nGenerators.tests.cpp:<line number>|nunexpected exception with message:|n "failure to init"- failure ignore as test marked as |'ok to fail|'|n']
##teamcity[testFinished name='#2615 - Throwing in constructor generator fails test case but does not abort' duration="{duration}"]
##teamcity[testStarted name='#2944 - Stringifying dates before 1970 should not crash']
##teamcity[testFinished name='#2944 - Stringifying dates before 1970 should not crash' duration="{duration}"]
##teamcity[testStarted name='#748 - captures with unexpected exceptions']
##teamcity[testIgnored name='#748 - captures with unexpected exceptions' message='-------------------------------------------------------------------------------|noutside assertions|n-------------------------------------------------------------------------------|nException.tests.cpp:<line number>|n...............................................................................|n|nException.tests.cpp:<line number>|nunexpected exception with messages:|n "answer := 42"|n "expected exception"- failure ignore as test marked as |'ok to fail|'|n']
##teamcity[testIgnored name='#748 - captures with unexpected exceptions' message='-------------------------------------------------------------------------------|ninside REQUIRE_NOTHROW|n-------------------------------------------------------------------------------|nException.tests.cpp:<line number>|n...............................................................................|n|nException.tests.cpp:<line number>|nunexpected exception with messages:|n "answer := 42"|n "expected exception"|n REQUIRE_NOTHROW( thisThrows() )|nwith expansion:|n thisThrows()|n- failure ignore as test marked as |'ok to fail|'|n']
Expand Down
Loading

0 comments on commit 39703a1

Please sign in to comment.